scripts/slave/recipe_modules/chromium_tests/api.py - Issue 1376453002: chromium_tests: raise infra failure when no compile targets are specified

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/api.py

Issue 1376453002: chromium_tests: raise infra failure when no compile targets are specified (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_android_Android_arm64_Builder__dbg_.json » ('j') | scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_tests/api.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py

index 39038f6fd1f69e472604bd6cea182ef5e272f0fd..b3cd8b0af92c0a84ee97b7e5a56f44ffe76639e8 100644

--- a/scripts/slave/recipe_modules/chromium_tests/api.py

+++ b/scripts/slave/recipe_modules/chromium_tests/api.py

@@ -447,6 +447,8 @@ class ChromiumTestsApi(recipe_api.RecipeApi):

isolated_targets=isolated_targets,

name='generate_build_files%s' % name_suffix)

+ if not compile_targets:

+ raise self.m.step.InfraFailure('Misconfigured bot: no compile targets')

self.m.chromium.compile(compile_targets, name='compile%s' % name_suffix)

def tests_for_builder(self, mastername, buildername, update_step, master_dict,