Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1376413003: Fix a leak in PDF_DataDecode() on failure. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a leak in PDF_DataDecode() on failure. Found using the test examples from https://crbug.com/537780 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/63d0a52a6af7d327fdb5792f520cc8d93fe2f1bb

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
Rewriting this with unique_ptr or std::vector will be for another day.
5 years, 2 months ago (2015-10-02 02:29:25 UTC) #2
Tom Sepez
lgtm
5 years, 2 months ago (2015-10-02 17:29:25 UTC) #3
Lei Zhang
5 years, 2 months ago (2015-10-02 17:56:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
63d0a52a6af7d327fdb5792f520cc8d93fe2f1bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698