Issue 1376353002: win: fix VirtualQueryEx on < win10

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1376353002: win: fix VirtualQueryEx on < win10 (Closed)

Created:
5 years, 2 months ago by scottmg

Modified:
5 years, 2 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

win: fix VirtualQueryEx on < win10 On Win10, VirtualQueryEx supports querying the x64 part of WOW64 processes. However, on lower OSs it errors past 2/3G. There's no direct way to retrieve to maximum memory address for processes other than yourself, but fortunately, VirtualQueryEx sets a distinct error code when `lpAddress` exceeds the maximum accessible address, so we can just terminate successfully in that case. R=mark@chromium.org BUG=crashpad:20, crashpad:46 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9d9302bb020e24455412595ee516f123a58c3444

Patch Set 1 #

Patch Set 2 : . #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -9 lines)			Patch
	M	util/win/process_info.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	util/win/process_info.cc	View	1	4 chunks	+14 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

5 years, 2 months ago (2015-10-01 00:20:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
9d9302bb020e24455412595ee516f123a58c3444 (presubmit successful).

Expand Messages | Collapse Messages