Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1376333003: Eliminate no_frame_range data (Closed)

Created:
5 years, 2 months ago by alph
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, yurys
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Eliminate no_frame_range data It was supposed to be used by the CPU profiler. But as long as these ranges are not built when profiler is not running, once the profiler is started there're no ranges for already compiled functions. So basically this code never worked. As long as now CPU profiler uses another approach this code is no longer needed. Committed: https://crrev.com/8d55da3830aadbf8f98b091f7a2f650af96aeb6a Cr-Commit-Position: refs/heads/master@{#31056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -136 lines) Patch
M src/arm/lithium-codegen-arm.cc View 3 chunks +1 line, -7 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M src/compiler.h View 3 chunks +0 lines, -20 lines 0 comments Download
M src/compiler.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 3 chunks +1 line, -4 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 3 chunks +1 line, -4 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M src/profiler/cpu-profiler.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M src/profiler/profile-generator.h View 3 chunks +0 lines, -7 lines 0 comments Download
M src/profiler/profile-generator.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M src/profiler/profile-generator-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/strings-storage.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376333003/1
5 years, 2 months ago (2015-09-30 22:43:36 UTC) #2
alph
ptal
5 years, 2 months ago (2015-09-30 23:02:05 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 23:07:09 UTC) #6
yurys
LGTM, Now with the new approach to the problem can we unskip test-cpu-profiler/SampleWhenFrameIsNotSetup ?
5 years, 2 months ago (2015-09-30 23:25:40 UTC) #7
alph
On 2015/09/30 23:25:40, yurys wrote: > LGTM, > > Now with the new approach to ...
5 years, 2 months ago (2015-09-30 23:31:20 UTC) #8
Benedikt Meurer
LGTM
5 years, 2 months ago (2015-10-01 07:14:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376333003/1
5 years, 2 months ago (2015-10-01 17:05:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 17:08:56 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 17:09:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d55da3830aadbf8f98b091f7a2f650af96aeb6a
Cr-Commit-Position: refs/heads/master@{#31056}

Powered by Google App Engine
This is Rietveld 408576698