Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 137633004: Add WorkerGlobalScope* param to WorkerReportingProxy::workerGlobalScopeStarted (Closed)

Created:
6 years, 11 months ago by kinuko
Modified:
6 years, 11 months ago
Reviewers:
adamk
CC:
blink-reviews, kinuko+watch
Visibility:
Public.

Description

Add WorkerGlobalScope* param to WorkerReportingProxy::workerGlobalScopeStarted To make ServiceWorker wiring slightly easier. (This method is currently used only by ServiceWorker) BUG=313530 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165404

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -50 lines) Patch
M Source/core/workers/WorkerObjectProxy.h View 1 chunk +29 lines, -29 lines 0 comments Download
M Source/core/workers/WorkerReportingProxy.h View 1 chunk +17 lines, -15 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 3 chunks +5 lines, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
Hi Adam, does this small change look ok to you? PTL thanks,
6 years, 11 months ago (2014-01-17 07:18:50 UTC) #1
adamk
Seems fine, lgtm
6 years, 11 months ago (2014-01-17 17:00:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/137633004/40001
6 years, 11 months ago (2014-01-20 01:30:29 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=18129
6 years, 11 months ago (2014-01-20 01:58:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/137633004/40001
6 years, 11 months ago (2014-01-20 12:34:32 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-20 13:20:21 UTC) #6
Message was sent while issue was closed.
Change committed as 165404

Powered by Google App Engine
This is Rietveld 408576698