Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1376313002: Check the current thread in AudioManagerBase::MakeAudio{Output,Input}Stream (Closed)

Created:
5 years, 2 months ago by ki.stfu
Modified:
5 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check the current thread in AudioManagerBase::MakeAudio{Output,Input}Stream BUG= TEST= R=tommi@chromium.org,henrika@chromium.org,miu@chromium.org Committed: https://crrev.com/ca3ac60f80128160b38d099e0c319667cdc60719 Cr-Commit-Position: refs/heads/master@{#352276}

Patch Set 1 #

Patch Set 2 : Fix chromecast/media/audio/cast_audio_output_stream_unittest.cc #

Patch Set 3 : Rebase against ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M media/audio/audio_manager_base.cc View 1 2 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
ki.stfu
5 years, 2 months ago (2015-09-30 20:32:29 UTC) #1
ki.stfu
On 2015/09/30 20:32:29, ki.stfu wrote: Hi! I checked that all audio and media tests passed ...
5 years, 2 months ago (2015-09-30 20:44:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376313002/1
5 years, 2 months ago (2015-09-30 21:29:00 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/61164)
5 years, 2 months ago (2015-09-30 22:01:16 UTC) #6
miu
lgtm, but it looks like you've exposed some threading bugs in the chromecast unit tests ...
5 years, 2 months ago (2015-10-01 01:02:53 UTC) #7
henrika (OOO until Aug 14)
LGTM
5 years, 2 months ago (2015-10-01 08:30:16 UTC) #9
tommi (sloooow) - chröme
nice :) would be good if the cast problems could be fixed too
5 years, 2 months ago (2015-10-01 10:24:45 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376313002/20001
5 years, 2 months ago (2015-10-04 08:43:27 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/121914)
5 years, 2 months ago (2015-10-04 08:44:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376313002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376313002/40001
5 years, 2 months ago (2015-10-04 08:51:30 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-04 12:53:59 UTC) #20
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ca3ac60f80128160b38d099e0c319667cdc60719 Cr-Commit-Position: refs/heads/master@{#352276}
5 years, 2 months ago (2015-10-04 12:54:57 UTC) #21
henrika (OOO until Aug 14)
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1384983002/ by henrika@chromium.org. ...
5 years, 2 months ago (2015-10-05 14:51:21 UTC) #22
ki.stfu
5 years, 2 months ago (2015-10-05 14:53:42 UTC) #23
Message was sent while issue was closed.
It broke Win7 Release (Intel) job:
http://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28Int...

Powered by Google App Engine
This is Rietveld 408576698