|
|
DescriptionCheck the current thread in AudioManagerBase::MakeAudio{Output,Input}Stream
BUG=
TEST=
R=tommi@chromium.org,henrika@chromium.org,miu@chromium.org
Committed: https://crrev.com/ca3ac60f80128160b38d099e0c319667cdc60719
Cr-Commit-Position: refs/heads/master@{#352276}
Patch Set 1 #Patch Set 2 : Fix chromecast/media/audio/cast_audio_output_stream_unittest.cc #Patch Set 3 : Rebase against ToT #Messages
Total messages: 23 (9 generated)
On 2015/09/30 20:32:29, ki.stfu wrote: Hi! I checked that all audio and media tests passed on Linux. Could you dry-run it for checking on other platforms?
The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376313002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
lgtm, but it looks like you've exposed some threading bugs in the chromecast unit tests that need to be fixed. ;-)
dalecurtis@chromium.org changed reviewers: - dalecurtis@chromium.org
LGTM
nice :) would be good if the cast problems could be fixed too
ki.stfu@gmail.com changed reviewers: + lcwu@chromium.org
The CQ bit was checked by ki.stfu@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376313002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ki.stfu@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from miu@chromium.org, henrika@chromium.org Link to the patchset: https://codereview.chromium.org/1376313002/#ps40001 (title: "Rebase against ToT")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376313002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376313002/40001
ki.stfu@gmail.com changed reviewers: - lcwu@chromium.org
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ca3ac60f80128160b38d099e0c319667cdc60719 Cr-Commit-Position: refs/heads/master@{#352276}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1384983002/ by henrika@chromium.org. The reason for reverting is: Seems to break some audio tests. See https://code.google.com/p/chromium/issues/detail?id=539362.
Message was sent while issue was closed.
It broke Win7 Release (Intel) job: http://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28Int... |