Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Issue 1376303002: PPC: [turbofan] Call ArgumentsAccessStub to materialize arguments. (Closed)

Created:
5 years, 2 months ago by MTBrandyberry
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Call ArgumentsAccessStub to materialize arguments. Port 9b12ec9ac2aff2978d05df775ce621ba4d90cbe8 Original commit message: This lowers JSCreateArgument nodes to call the ArgumentsAccessStub for help with materializing arguments objects when possible. Along the way this changes the calling convention of said stub to take parameters in registers instead of on the stack. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/8de7235cafa2b8a0666682f052e6ad46caf89e41 Cr-Commit-Position: refs/heads/master@{#31033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -180 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +12 lines, -17 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 10 chunks +151 lines, -163 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
MTBrandyberry
5 years, 2 months ago (2015-09-30 20:27:31 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376303002/1
5 years, 2 months ago (2015-09-30 20:27:45 UTC) #3
michael_dawson
On 2015/09/30 20:27:45, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 2 months ago (2015-09-30 20:58:10 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 21:04:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376303002/1
5 years, 2 months ago (2015-09-30 21:05:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 21:07:20 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 21:07:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8de7235cafa2b8a0666682f052e6ad46caf89e41
Cr-Commit-Position: refs/heads/master@{#31033}

Powered by Google App Engine
This is Rietveld 408576698