test/unittests/compiler/scheduler-unittest.cc - Issue 1376293005: [turbofan] Redundant branch elimination.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/scheduler-unittest.cc

Issue 1376293005: [turbofan] Redundant branch elimination. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Loop test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/compiler/scheduler-unittest.cc

diff --git a/test/unittests/compiler/scheduler-unittest.cc b/test/unittests/compiler/scheduler-unittest.cc

index 45d555d7a143697e841d4799316a7f656a4171cc..a59d74a193767c1e5e65796c519ee7aec5deba6c 100644

--- a/test/unittests/compiler/scheduler-unittest.cc

+++ b/test/unittests/compiler/scheduler-unittest.cc

@@ -1124,7 +1124,7 @@ TARGET_TEST_F(SchedulerTest, Terminate) {

Node* loop = graph()->NewNode(common()->Loop(2), start, start);

loop->ReplaceInput(1, loop); // self loop, NTL.

- Node* effect = graph()->NewNode(common()->EffectPhi(1), start, loop);

+ Node* effect = graph()->NewNode(common()->EffectPhi(2), start, start, loop);

Node* terminate = graph()->NewNode(common()->Terminate(), effect, loop);

effect->ReplaceInput(1, terminate);