Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 1376283002: Revert of Added some browsertests to PageLoadMetrics change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hijack_bryans_cl
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/page_load_metrics/OWNERS ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
deleted file mode 100644
index ac828737fc1ea3516a46a7e28b643036590887da..0000000000000000000000000000000000000000
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
+++ /dev/null
@@ -1,64 +0,0 @@
-// Copyright (c) 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/test/histogram_tester.h"
-#include "chrome/test/base/in_process_browser_test.h"
-#include "chrome/test/base/ui_test_utils.h"
-#include "net/test/spawned_test_server/spawned_test_server.h"
-
-namespace page_load_metrics {
-
-class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest {
- public:
- const char* kHistogramNameFirstLayout =
- "PageLoad.Timing.NavigationToFirstLayout";
- const char* kHistogramNameDomContent =
- "PageLoad.Timing.NavigationToDOMContentLoadedEventFired";
- const char* kHistogramNameLoad = "PageLoad.Timing.NavigationToLoadEventFired";
- MetricsWebContentsObserverBrowserTest() {};
- ~MetricsWebContentsObserverBrowserTest() override {};
-
- protected:
- base::HistogramTester histogram_tester_;
-
- DISALLOW_COPY_AND_ASSIGN(MetricsWebContentsObserverBrowserTest);
-};
-
-IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NoNavigation) {
- ASSERT_TRUE(test_server()->Start());
-
- histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 0);
- histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 0);
- histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 0);
-}
-
-IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, NewPage) {
- ASSERT_TRUE(test_server()->Start());
-
- ui_test_utils::NavigateToURL(browser(),
- test_server()->GetURL("/title1.html"));
- ui_test_utils::NavigateToURL(browser(),
- test_server()->GetURL("/title2.html"));
-
- histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 1);
- histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 1);
- histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 1);
-}
-
-IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AnchorLink) {
- ASSERT_TRUE(test_server()->Start());
-
- ui_test_utils::NavigateToURL(browser(),
- test_server()->GetURL("/title1.html"));
- ui_test_utils::NavigateToURL(browser(),
- test_server()->GetURL("/title1.html#hash"));
- ui_test_utils::NavigateToURL(browser(),
- test_server()->GetURL("/title2.html"));
-
- histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 1);
- histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 1);
- histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 1);
-}
-
-} // namespace page_load_metrics
« no previous file with comments | « chrome/browser/page_load_metrics/OWNERS ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698