Issue 1376283002: Revert of Added some browsertests to PageLoadMetrics change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1376283002: Revert of Added some browsertests to PageLoadMetrics change (Closed)

Created:
5 years, 2 months ago by jwd

Modified:
5 years, 2 months ago

Reviewers:
Bryan McQuade, jochen (gone - plz use gerrit), Charlie Harrison

CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, sdefresne+watchlist_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@hijack_bryans_cl

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Added some browsertests to PageLoadMetrics change (patchset #4 id:60001 of https://codereview.chromium.org/1317263004/ ) Reason for revert: AnchorLink and NewPage tests failing on bots https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/10223 Original issue's description: > Added some browsertests to PageLoadMetrics change > > BUG=382542 > > Committed: https://crrev.com/0b7f2aec3f912c47810b3d044eabbc320cbca170 > Cr-Commit-Position: refs/heads/master@{#351603} TBR=jochen@chromium.org,bmcquade@chromium.org,csharrison@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=382542 Committed: https://crrev.com/4245dce7720ddc122e42bd5429d2e5e5c88db371 Cr-Commit-Position: refs/heads/master@{#351617}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -68 lines)			Patch
D	chrome/browser/page_load_metrics/OWNERS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc	View	1 chunk	+0 lines, -64 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jwd

Created Revert of Added some browsertests to PageLoadMetrics change

5 years, 2 months ago (2015-09-30 19:24:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376283002/1

5 years, 2 months ago (2015-09-30 19:26:28 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-09-30 19:30:12 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4245dce7720ddc122e42bd5429d2e5e5c88db371
Cr-Commit-Position: refs/heads/master@{#351617}

Expand Messages | Collapse Messages