runtime/vm/flow_graph_compiler_ia32.cc - Issue 1376233011: Partially revert r26703 and omit regular code generation for implicit accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 1376233011: Partially revert r26703 and omit regular code generation for implicit accessors. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_ia32.cc

diff --git a/runtime/vm/flow_graph_compiler_ia32.cc b/runtime/vm/flow_graph_compiler_ia32.cc

index 2c7b3353684aa2703dcde1aa8f294c78153a4184..2794ff56476c21fd7b7bf13ba3e0a97001fc0e60 100644

--- a/runtime/vm/flow_graph_compiler_ia32.cc

+++ b/runtime/vm/flow_graph_compiler_ia32.cc

@@ -1030,7 +1030,10 @@ void FlowGraphCompiler::EmitFrameEntry() {

void FlowGraphCompiler::CompileGraph() {

InitCompiler();

- TryIntrinsify();

+ if (TryIntrinsify()) {

+ // Skip regular code generation.

+ return;

+ }

EmitFrameEntry();

« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »