Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 137623018: NaCl: Update to use new embedding interface provided by chrome_main.h (Closed)

Created:
6 years, 10 months ago by Mark Seaborn
Modified:
6 years, 10 months ago
Reviewers:
bradn
CC:
chromium-reviews, hidehiko
Visibility:
Public.

Description

NaCl: Update to use new embedding interface provided by chrome_main.h BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734 BUG=https://code.google.com/p/nativeclient/issues/detail?id=2832 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M components/nacl/loader/nacl_listener.cc View 5 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Seaborn
This depends on https://codereview.chromium.org/153453002/ being rolled into Chromium.
6 years, 10 months ago (2014-02-05 22:24:19 UTC) #1
bradn
lgtm
6 years, 10 months ago (2014-02-05 23:13:18 UTC) #2
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 10 months ago (2014-02-06 05:03:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/137623018/1
6 years, 10 months ago (2014-02-06 05:04:00 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 11:50:10 UTC) #5
Message was sent while issue was closed.
Change committed as 249370

Powered by Google App Engine
This is Rietveld 408576698