mojo/public/shell/lib/service.cc - Issue 137623017: Cleanup Service<> and ServiceFactory<> when clients go away.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/public/shell/lib/service.cc

Issue 137623017: Cleanup Service<> and ServiceFactory<> when clients go away. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "mojo/public/shell/service.h"	5 #include "mojo/public/shell/service.h"

6	6

7 namespace mojo {	7 namespace mojo {

8	8

9 ServiceFactoryBase::ServiceFactoryBase(ScopedMessagePipeHandle shell_handle)	9 ServiceFactoryBase::ServiceFactoryBase(ScopedMessagePipeHandle shell_handle)

10 : shell_(shell_handle.Pass(), this) {	10 : shell_(shell_handle.Pass(), this) {

11 }	11 }

12	12

13 ServiceFactoryBase::~ServiceFactoryBase() {}	13 ServiceFactoryBase::~ServiceFactoryBase() {}

14	14

	15 void ServiceFactoryBase::DisconnectFromShell() {

	16 shell_.reset();
	darin (slow to review) 2014/02/06 05:00:46 It seems like at this point we should be quiting t It seems like at this point we should be quiting the RunLoop so that MojoMain exits.
	17 }

	18

15 } // namespace mojo	19 } // namespace mojo

OLD	NEW