Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Unified Diff: chrome/common/localized_error.h

Issue 137623011: Switch to using the new Link Doctor API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Response to pkasting's comments, part 2 Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/localized_error.h
===================================================================
--- chrome/common/localized_error.h (revision 248295)
+++ chrome/common/localized_error.h (working copy)
@@ -8,12 +8,13 @@
#include <string>
#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
#include "base/strings/string16.h"
+#include "url/gurl.h"
-class GURL;
-
namespace base {
class DictionaryValue;
+class ListValue;
}
namespace extensions {
@@ -26,6 +27,26 @@
class LocalizedError {
public:
+ // Optional parameters that affect the display of an error page.
+ struct ErrorPageParams {
+ ErrorPageParams();
+ ~ErrorPageParams();
+
+ // Overrides whether reloading is suggested.
+ bool suggest_reload;
+
+ // Overrides default suggestions. Each entry must contain a header and may
+ // optionally contain a body as well.
+ scoped_ptr<base::ListValue> override_suggestions;
Nico 2014/02/06 17:58:32 optional: could maybe just be a ListValue, not a p
+
+ // Prefix to prepend to search terms. Search box is only shown if this is
+ // a valid url. Currently only Google searches are supported (Must use
+ // GET with a query parameter named "q").
+ GURL search_url;
+ // Default search terms. Ignored if |search_prefix| is invalid.
Nico 2014/02/06 17:58:32 You probably mean |search_url| here
mmenke 2014/02/06 22:00:32 Done.
+ std::string search_terms;
+ };
+
// Fills |error_strings| with values to be used to build an error page used
// on HTTP errors, like 404 or connection reset.
static void GetStrings(int error_code,
@@ -34,6 +55,7 @@
bool is_post,
const std::string& locale,
const std::string& accept_languages,
+ scoped_ptr<ErrorPageParams> params,
base::DictionaryValue* strings);
// Returns a description of the encountered error.

Powered by Google App Engine
This is Rietveld 408576698