chrome/renderer/resources/neterror.html - Issue 137623011: Switch to using the new Link Doctor API.

Side by Side Diff: chrome/renderer/resources/neterror.html

Issue 137623011: Switch to using the new Link Doctor API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Response to pkasting's comments, part 2 Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="dir:textdirection">	2 <html i18n-values="dir:textdirection">

3 <head>	3 <head>

4 <meta name="viewport" content="width=device-width, initial-scale=1.0,	4 <meta name="viewport" content="width=device-width, initial-scale=1.0,

5 maximum-scale=1.0, user-scalable=no">	5 maximum-scale=1.0, user-scalable=no">

6 <title i18n-content="title"></title>	6 <title i18n-content="title"></title>

7 <link rel="stylesheet" href="neterror.css">	7 <link rel="stylesheet" href="neterror.css">

8 <script src="neterror.js"></script>	8 <script src="neterror.js"></script>

9 </head>	9 </head>

10 <body id="t">	10 <body id="t">

11 <div id="main-frame-error">	11 <div id="main-frame-error">

12 <div id="box">	12 <div id="box">

13 <div id="content-top">	13 <div id="content-top">

14 <h1>	14 <h1>

15 <div>	15 <div>

16 <img class="icon"	16 <img class="icon"

17 jseval="updateIconClass(this.classList, iconClass)">	17 jseval="updateIconClass(this.classList, iconClass)">

18 </div>	18 </div>

19 <span i18n-content="heading"></span>	19 <span i18n-content="heading"></span>

20 </h1>	20 </h1>

21 <div id="buttons">	21 <div id="buttons">

22 <button id="reload-button" onclick="location = this.url"	22 <button id="reload-button" class="blue-button text-button"

	23 onclick="location = this.url"

23 jsselect="reload" jsvalues=".url:reloadUrl"	24 jsselect="reload" jsvalues=".url:reloadUrl"

24 jscontent="msg"></button>	25 jscontent="msg"></button>

25 <button id="more-less-button" onclick="toggleHelpBox()"	26 <button id="more-less-button" class="text-button"

26 jsdisplay="more" jsvalues=".moreText:more; .lessText:less;"	27 onclick="toggleHelpBox()" jsdisplay="more"

	28 jsvalues=".moreText:more; .lessText:less;"

27 jscontent="more"></button>	29 jscontent="more"></button>

28 </div>	30 </div>

29 </div>	31 </div>

30 <!-- Outer and inner divs are needed both for margins and sizing. -->	32 <!-- Outer and inner divs are needed both for margins and sizing. -->

31 <div id="help-box-outer" class="hidden">	33 <div id="help-box-outer" class="hidden">

32 <div id="help-box-inner">	34 <div id="help-box-inner">

33 <div jsselect="summary">	35 <div jsselect="summary">

34 <span jsvalues=".innerHTML:msg"></span>	36 <span jsvalues=".innerHTML:msg"></span>

35 </div>	37 </div>

36 <div class="suggestions" jsselect="suggestions">	38 <div class="suggestions" jsselect="suggestions">

37 <div class="suggestion-header" jsvalues=".innerHTML:header"></div>	39 <div class="suggestion-header" jsvalues=".innerHTML:header"></div>

38 <div class="suggestion-body" jsvalues=".innerHTML:body"></div>	40 <div class="suggestion-body" jsvalues=".innerHTML:body"></div>

39 </div>	41 </div>

40 <button id="diagnose-button" onclick="diagnoseErrors()"	42 <button class="text-button" id="diagnose-button"

41 jscontent="diagnose" jsdisplay="diagnose"></button>	43 onclick="diagnoseErrors()" jscontent="diagnose"

	44 jsdisplay="diagnose"></button>

42 <div id="diagnose-frame" class="hidden"></div>	45 <div id="diagnose-frame" class="hidden"></div>

	46 <form method="get" class="suggestions" jsvalues=".action:searchUrl"

	47 jsdisplay="searchUrl">

	48 <div class="suggestion-header" jscontent="searchHeader"></div>

	49 <div id="search-container">

	50 <input type="text" name="q" id="search-box"

	51 jsvalues=".value:searchTerms" />
	Nico 2014/02/06 17:58:32 hm, maybe the search query param name should be pa hm, maybe the search query param name should be part of search_url and be passed in? (Part of search_url in the cc file, passed as separate parameter here). Hardcoding q here seems a bit iffy. mmenke 2014/02/06 22:00:32 Done, no argument that it was iffy. I was worried Show quoted text On 2014/02/06 17:58:32, Nico wrote: > hm, maybe the search query param name should be part of search_url and be passed > in? (Part of search_url in the cc file, passed as separate parameter here). > Hardcoding q here seems a bit iffy. Done, no argument that it was iffy. I was worried about stuffing a string with spaces or non-ASCII characters directly into a string and using it as a URL, but I suppose we're smart enough to do that correctly.
	52 <button type="submit" id="search-button" class="blue-button"

	53 onclick="diagnoseErrors()" jsvalues="aria-label:searchHeader">

	54 <img id="search-image"></img>

	55 </button>

	56 </div>

	57 </form>

43 <div class="error-code" jscontent="errorCode"></div>	58 <div class="error-code" jscontent="errorCode"></div>

44 </div>	59 </div>

45 </div>	60 </div>

46 </div>	61 </div>

47 </div>	62 </div>

48 <div id="sub-frame-error">	63 <div id="sub-frame-error">

49 <!-- Show details when hovering over the icon, in case the details are	64 <!-- Show details when hovering over the icon, in case the details are

50 hidden because they're too large. -->	65 hidden because they're too large. -->

51 <img class="icon" jseval="updateIconClass(this.classList, iconClass)"	66 <img class="icon" jseval="updateIconClass(this.classList, iconClass)"

52 jsvalues=".title:errorDetails">	67 jsvalues=".title:errorDetails">

53 <div id="sub-frame-error-details" jsvalues=".innerHTML:errorDetails"></div>	68 <div id="sub-frame-error-details" jsvalues=".innerHTML:errorDetails"></div>

54 </div>	69 </div>

55 </body>	70 </body>

56 </html>	71 </html>

OLD	NEW

« chrome/renderer/resources/neterror.css ('K') | « chrome/renderer/resources/neterror.css ('k') | chrome/test/data/mock-link-doctor.html » ('j') | no next file with comments »