base/metrics/histogram_base.h - Issue 137623002: Let MetricsService know about some Android Activities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_base.h

Issue 137623002: Let MetricsService know about some Android Activities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unnecessary ConvertAndroidStabilityPrefsToHistograms() call and added missing OVERRIDE Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/histogram_base.h

diff --git a/base/metrics/histogram_base.h b/base/metrics/histogram_base.h

index 11b9a45b3831630f0841fb484988a111460d747b..566b4752f68ea0c35d2d85536ca5f2df22889250 100644

--- a/base/metrics/histogram_base.h

+++ b/base/metrics/histogram_base.h

@@ -58,6 +58,9 @@ class BASE_EXPORT HistogramBase {

kNoFlags = 0,

kUmaTargetedHistogramFlag = 0x1, // Histogram should be UMA uploaded.

Alexei Svitkine (slow) 2014/01/27 19:12:54 Nit: Can you move the comment above this line to b

Kibeom Kim (inactive) 2014/01/29 01:52:32 Done.

+ // Indicate that this is a stability histogram.

Alexei Svitkine (slow) 2014/01/27 19:12:54 Nit: "Indicate" -> "Indicates". Can you fix the co

Kibeom Kim (inactive) 2014/01/29 01:52:32 Done.

+ kStabilityHistogramFlag = 0x2,

// Indicate that the histogram was pickled to be sent across an IPC Channel.

// If we observe this flag on a histogram being aggregated into after IPC,

// then we are running in a single process mode, and the aggregation should

« base/metrics/histogram.h ('K') | « base/metrics/histogram.h ('k') | base/metrics/histogram_delta_serialization.cc » ('j') | base/metrics/histogram_snapshot_manager_unittest.cc » ('J')