base/metrics/histogram_snapshot_manager.h - Issue 137623002: Let MetricsService know about some Android Activities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_snapshot_manager.h

Issue 137623002: Let MetricsService know about some Android Activities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert 0 to Histogram::kNoFlags Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/metrics/histogram_base.h ('K') | « base/metrics/histogram_delta_serialization.cc ('k') | base/metrics/histogram_snapshot_manager.cc » ('j') | chrome/browser/metrics/metrics_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/metrics/histogram_snapshot_manager.h

diff --git a/base/metrics/histogram_snapshot_manager.h b/base/metrics/histogram_snapshot_manager.h

index 3c7050859e3f92230a83a491a364585eed57db91..a16320f7a0351c9e58e9d4cf9df1ad2e04efb16d 100644

--- a/base/metrics/histogram_snapshot_manager.h

+++ b/base/metrics/histogram_snapshot_manager.h

@@ -31,7 +31,10 @@ class BASE_EXPORT HistogramSnapshotManager {

// Snapshot all histograms, and ask |histogram_flattener_| to record the

// delta. The arguments allow selecting only a subset of histograms for

// recording, or to set a flag in each recorded histogram.

Alexei Svitkine (slow) 2014/01/22 21:14:19 Please expand comment to explain |flag_filter_to_r

Kibeom Kim (inactive) 2014/01/24 19:45:09 Done.

- void PrepareDeltas(HistogramBase::Flags flags_to_set, bool record_only_uma);

+ // If everything need to be recorded, set |flag_filter_to_record| to

+ // Histogram::kNoFlags .

+ void PrepareDeltas(HistogramBase::Flags flags_to_set,

+ HistogramBase::Flags flag_filter_to_record);

private:

// Snapshot this histogram, and record the delta.