base/metrics/histogram_snapshot_manager.cc - Issue 137623002: Let MetricsService know about some Android Activities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_snapshot_manager.cc

Issue 137623002: Let MetricsService know about some Android Activities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/metrics/histogram_snapshot_manager.h ('k') | base/metrics/histogram_snapshot_manager_unittest.cc » ('j') | chrome/browser/metrics/metrics_service_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/metrics/histogram_snapshot_manager.cc

diff --git a/base/metrics/histogram_snapshot_manager.cc b/base/metrics/histogram_snapshot_manager.cc

index cb594bd96d99abccceb48ee0d5d69d620c8277e0..b1e26da59dcf30d70be39390e742297e17cb6926 100644

--- a/base/metrics/histogram_snapshot_manager.cc

+++ b/base/metrics/histogram_snapshot_manager.cc

@@ -25,18 +25,17 @@ HistogramSnapshotManager::~HistogramSnapshotManager() {

STLDeleteValues(&logged_samples_);

}

-void HistogramSnapshotManager::PrepareDeltas(HistogramBase::Flags flag_to_set,

- bool record_only_uma) {

+void HistogramSnapshotManager::PrepareDeltas(

+ HistogramBase::Flags flag_to_set,

+ HistogramBase::Flags required_flags) {

StatisticsRecorder::Histograms histograms;

StatisticsRecorder::GetHistograms(&histograms);

for (StatisticsRecorder::Histograms::const_iterator it = histograms.begin();

histograms.end() != it;

++it) {

(*it)->SetFlags(flag_to_set);

- if (record_only_uma &&

- 0 == ((*it)->flags() & Histogram::kUmaTargetedHistogramFlag))

- continue;

- PrepareDelta(**it);

+ if (((*it)->flags() & required_flags) == required_flags)

+ PrepareDelta(**it);

}