chrome/common/metrics/metrics_service_base.cc - Issue 137623002: Let MetricsService know about some Android Activities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/metrics/metrics_service_base.cc

Issue 137623002: Let MetricsService know about some Android Activities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: line warp fix Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/metrics/metrics_service_base.h ('K') | « chrome/common/metrics/metrics_service_base.h ('k') | chrome/common/pref_names.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/metrics/metrics_service_base.cc

diff --git a/chrome/common/metrics/metrics_service_base.cc b/chrome/common/metrics/metrics_service_base.cc

index 5f4edc25e44f8f82901d7ea88ee33de5104ab026..66e823877f7510609810f15f068b024356e3000d 100644

--- a/chrome/common/metrics/metrics_service_base.cc

+++ b/chrome/common/metrics/metrics_service_base.cc

@@ -26,7 +26,14 @@ const char MetricsServiceBase::kMimeType[] = "application/vnd.chrome.uma";

void MetricsServiceBase::RecordCurrentHistograms() {

DCHECK(log_manager_.current_log());

- histogram_snapshot_manager_.PrepareDeltas(base::Histogram::kNoFlags, true);

+ histogram_snapshot_manager_.PrepareDeltas(

+ base::Histogram::kNoFlags, base::Histogram::kUmaTargetedHistogramFlag);

+void MetricsServiceBase::RecordCurrentStabilityHistograms() {

+ DCHECK(log_manager_.current_log());

+ histogram_snapshot_manager_.PrepareDeltas(

+ base::Histogram::kNoFlags, base::Histogram::kUmaStabilityHistogramFlag);

}

void MetricsServiceBase::RecordDelta(

« chrome/common/metrics/metrics_service_base.h ('K') | « chrome/common/metrics/metrics_service_base.h ('k') | chrome/common/pref_names.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')