Let MetricsService know about some Android Activities

chrome/common/metrics/metrics_service_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/metrics/metrics_service_base.h"
 
 #include <cstdlib>
 
 #include "chrome/common/metrics/metrics_log_base.h"
 
 using base::Histogram;
 
 MetricsServiceBase::MetricsServiceBase()
     : histogram_snapshot_manager_(this) {
 }
 
 MetricsServiceBase::~MetricsServiceBase() {
 }
 
 // static
 const char MetricsServiceBase::kServerUrl[] =
     "https://clients4.google.com/uma/v2";
 
 // static
 const char MetricsServiceBase::kMimeType[] = "application/vnd.chrome.uma";
 
 void MetricsServiceBase::RecordCurrentHistograms() {
   DCHECK(log_manager_.current_log());
-  histogram_snapshot_manager_.PrepareDeltas(base::Histogram::kNoFlags, true);
+  histogram_snapshot_manager_.PrepareDeltas(
+      base::Histogram::kNoFlags, base::Histogram::kUmaTargetedHistogramFlag);
+}
+
+void MetricsServiceBase::RecordCurrentStabilityHistograms() {
+  DCHECK(log_manager_.current_log());
+  histogram_snapshot_manager_.PrepareDeltas(
+      base::Histogram::kNoFlags,
+      static_cast<base::Histogram::Flags>(

[Alexei Svitkine (slow), 2014/01/27 19:12:54]

This cast is kind of ugly, but I understand why it's there.

I know I'm changing my mind here, but now I think it would be better to have the
stability histogram mean both UMA and Stability, so that this isn't needed.

However I think it can be defined thus:

  kUmaStabilityHistogramFlag = kUmaTargetedHistogramFlag | 0x2,

That way, code checking for just kUmaTargetedHistogramFlag will still include
these (without needing special handling), but this code can just pass in
kUmaTargetedHistogramFlag without ugly casts.

[Kibeom Kim (inactive), 2014/01/29 01:52:32]

Done. (nice suggestion!)

+          base::Histogram::kUmaTargetedHistogramFlag |
+          base::Histogram::kStabilityHistogramFlag));
 }
 
 void MetricsServiceBase::RecordDelta(
     const base::HistogramBase& histogram,
     const base::HistogramSamples& snapshot) {
   log_manager_.current_log()->RecordHistogramDelta(histogram.histogram_name(),
                                                    snapshot);
 }
 
 void MetricsServiceBase::InconsistencyDetected(
     base::HistogramBase::Inconsistency problem) {
   UMA_HISTOGRAM_ENUMERATION("Histogram.InconsistenciesBrowser",
                             problem, base::HistogramBase::NEVER_EXCEEDED_VALUE);
 }
 
 void MetricsServiceBase::UniqueInconsistencyDetected(
     base::HistogramBase::Inconsistency problem) {
   UMA_HISTOGRAM_ENUMERATION("Histogram.InconsistenciesBrowserUnique",
                             problem, base::HistogramBase::NEVER_EXCEEDED_VALUE);
 }
 
 void MetricsServiceBase::InconsistencyDetectedInLoggedCount(int amount) {
   UMA_HISTOGRAM_COUNTS("Histogram.InconsistentSnapshotBrowser",
                        std::abs(amount));
 }