Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: base/metrics/histogram_base.h

Issue 137623002: Let MetricsService know about some Android Activities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert 0 to Histogram::kNoFlags Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_METRICS_HISTOGRAM_BASE_H_ 5 #ifndef BASE_METRICS_HISTOGRAM_BASE_H_
6 #define BASE_METRICS_HISTOGRAM_BASE_H_ 6 #define BASE_METRICS_HISTOGRAM_BASE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 public: 50 public:
51 typedef int Sample; // Used for samples. 51 typedef int Sample; // Used for samples.
52 typedef subtle::Atomic32 Count; // Used to count samples. 52 typedef subtle::Atomic32 Count; // Used to count samples.
53 53
54 static const Sample kSampleType_MAX; // INT_MAX 54 static const Sample kSampleType_MAX; // INT_MAX
55 55
56 enum Flags { 56 enum Flags {
57 kNoFlags = 0, 57 kNoFlags = 0,
58 kUmaTargetedHistogramFlag = 0x1, // Histogram should be UMA uploaded. 58 kUmaTargetedHistogramFlag = 0x1, // Histogram should be UMA uploaded.
59 59
60 // Histogram should be UMA uploaded, but as a part of initial stability log.
61 kUmaTargetedStabilityHistogramFlag =0x2,
Alexei Svitkine (slow) 2014/01/22 21:14:19 I think the flag should mention it's an Stability
Kibeom Kim (inactive) 2014/01/24 19:45:09 Done.
62
60 // Indicate that the histogram was pickled to be sent across an IPC Channel. 63 // Indicate that the histogram was pickled to be sent across an IPC Channel.
61 // If we observe this flag on a histogram being aggregated into after IPC, 64 // If we observe this flag on a histogram being aggregated into after IPC,
62 // then we are running in a single process mode, and the aggregation should 65 // then we are running in a single process mode, and the aggregation should
63 // not take place (as we would be aggregating back into the source 66 // not take place (as we would be aggregating back into the source
64 // histogram!). 67 // histogram!).
65 kIPCSerializationSourceFlag = 0x10, 68 kIPCSerializationSourceFlag = 0x10,
66 69
67 // Only for Histogram and its sub classes: fancy bucket-naming support. 70 // Only for Histogram and its sub classes: fancy bucket-naming support.
68 kHexRangePrintingFlag = 0x8000, 71 kHexRangePrintingFlag = 0x8000,
69 }; 72 };
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 private: 163 private:
161 const std::string histogram_name_; 164 const std::string histogram_name_;
162 int32 flags_; 165 int32 flags_;
163 166
164 DISALLOW_COPY_AND_ASSIGN(HistogramBase); 167 DISALLOW_COPY_AND_ASSIGN(HistogramBase);
165 }; 168 };
166 169
167 } // namespace base 170 } // namespace base
168 171
169 #endif // BASE_METRICS_HISTOGRAM_BASE_H_ 172 #endif // BASE_METRICS_HISTOGRAM_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698