Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1376153002: Clear BodyStreamBuffer::m_handle in close()/error() (Closed)

Created:
5 years, 2 months ago by hiroshige
Modified:
5 years, 2 months ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear BodyStreamBuffer::m_handle in close()/error() After close()/error() is called, |m_handle| is no longer used but not cleared until lock() is called or BodyStreamBuffer is garbage collected. This leads data transfer to continue after reader is cancelled from JavaScript. This CL clears m_handle in close()/error() to destruct both the reader and handle of the source of BodyStreamBuffer and to stop transfer immediately. BUG=537286 Committed: https://crrev.com/ac0ed659d89e881943da62e2488099696fe1b676 Cr-Commit-Position: refs/heads/master@{#351555}

Patch Set 1 #

Patch Set 2 : Add unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 1 2 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376153002/1
5 years, 2 months ago (2015-09-30 06:44:53 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376153002/20001
5 years, 2 months ago (2015-09-30 07:56:28 UTC) #4
hiroshige
PTAL.
5 years, 2 months ago (2015-09-30 08:03:48 UTC) #6
yhirano
lgtm, thanks!
5 years, 2 months ago (2015-09-30 09:29:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376153002/20001
5 years, 2 months ago (2015-09-30 09:34:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/75615)
5 years, 2 months ago (2015-09-30 12:15:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376153002/20001
5 years, 2 months ago (2015-09-30 13:30:52 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-30 14:53:49 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 14:54:40 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ac0ed659d89e881943da62e2488099696fe1b676
Cr-Commit-Position: refs/heads/master@{#351555}

Powered by Google App Engine
This is Rietveld 408576698