Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 1376143006: [heap] Fix test-heap/PromotionQueue test. (Closed)

Created:
5 years, 2 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix test-heap/PromotionQueue test. BUG= Committed: https://crrev.com/faa640954ab825fbc4b42869b90857cef22342a0 Cr-Commit-Position: refs/heads/master@{#31085}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M test/cctest/test-heap.cc View 1 4 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Hannes Payer (out of office)
https://codereview.chromium.org/1376143006/diff/1/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/1376143006/diff/1/test/cctest/test-heap.cc#newcode5639 test/cctest/test-heap.cc:5639: heap->CollectGarbage(NEW_SPACE); Unfortunately, we cannot assert that.
5 years, 2 months ago (2015-10-01 15:02:33 UTC) #2
ulan
lgtm
5 years, 2 months ago (2015-10-02 15:31:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376143006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376143006/20001
5 years, 2 months ago (2015-10-02 15:32:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-02 15:55:13 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 15:55:24 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/faa640954ab825fbc4b42869b90857cef22342a0
Cr-Commit-Position: refs/heads/master@{#31085}

Powered by Google App Engine
This is Rietveld 408576698