Add a document phase for calculating paint properties

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 2420 matching lines @@
         ASSERT(lifecycle().state() >= DocumentLifecycle::CompositingClean);
 
         if (phases == AllPhases) {
             invalidateTreeIfNeededRecursive();
 
             if (view->compositor()->inCompositingMode())
                 scrollingCoordinator()->updateAfterCompositingChangeIfNeeded();
 
             updateCompositedSelectionIfNeeded();
 
+            if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+                calculatePaintProperties();
+
             if (RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled()) {
                 synchronizedPaint(interestRect);
                 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
                     compositeForSlimmingPaintV2();
             }
 
             if (RuntimeEnabledFeatures::frameTimingSupportEnabled())
                 updateFrameTimingRequestsIfNeeded();
 
             ASSERT(!view->hasPendingSelection());
             ASSERT(lifecycle().state() == DocumentLifecycle::PaintInvalidationClean
                 || (RuntimeEnabledFeatures::slimmingPaintV2Enabled() && lifecycle().state() == DocumentLifecycle::CompositingForSlimmingPaintV2Clean)
                 || (RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled() && lifecycle().state() == DocumentLifecycle::PaintClean));
         }
     }
 }
 
+void FrameView::calculatePaintProperties()

[esprehn, 2015/10/01 09:05:07]

recalcPaintProperties would match the verbage we use in other parts of the
engine

(or updatePaintProperties).

+{
+    ASSERT(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
+
+    lifecycle().advanceTo(DocumentLifecycle::InCalcPaintProps);
+    // TODO(pdr): Calculate the paint properties by walking the layout tree.

[esprehn, 2015/10/01 09:00:08]

That design doc is very light on details, how will you track dirty bits, what
invalidates this phase? What avoids walking the entire layout tree?

+    lifecycle().advanceTo(DocumentLifecycle::CalcPaintPropsClean);
+}
+
 void FrameView::synchronizedPaint(const LayoutRect& interestRect)
 {
     ASSERT(RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled());
     ASSERT(frame() == page()->mainFrame() || (!frame().tree().parent()->isLocalFrame()));
 
     LayoutView* view = layoutView();
     ASSERT(view);
     // TODO(chrishtr): figure out if there can be any GraphicsLayer above this one that draws content.
     GraphicsLayer* rootGraphicsLayer = view->layer()->graphicsLayerBacking();
     lifecycle().advanceTo(DocumentLifecycle::InPaint);
@@ skipping 1465 matching lines @@
 
     if (!graphicsLayer)
         return;
 
     DeprecatedPaintLayer::mapRectToPaintInvalidationBacking(localFrame->contentLayoutObject(), paintInvalidationContainer, viewRect);
 
     graphicsLayerTimingRequests.add(graphicsLayer, Vector<std::pair<int64_t, WebRect>>()).storedValue->value.append(std::make_pair(m_frame->frameID(), enclosingIntRect(viewRect)));
 }
 
 } // namespace blink