Issue 1376133002: tools/gn: Fix for bootstrap.py to keep it working.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1376133002: tools/gn: Fix for bootstrap.py to keep it working. (Closed)

Created:
5 years, 2 months ago by tfarina

Modified:
5 years, 2 months ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina, Dirk Pranke

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

tools/gn: Fix for bootstrap.py to keep it working. It was missing a trace_event source file to keep things compiling. BUG=None TEST=./tools/gn/bootstrap/bootstrap.py TBR=brettw@chromium.org Committed: https://crrev.com/38275d22a667c2da73c35ab3cd2b8c26f86c9411 Cr-Commit-Position: refs/heads/master@{#351491}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tools/gn/bootstrap/bootstrap.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376133002/1

5 years, 2 months ago (2015-09-30 04:19:53 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/38275d22a667c2da73c35ab3cd2b8c26f86c9411 Cr-Commit-Position: refs/heads/master@{#351491}

5 years, 2 months ago (2015-09-30 04:53:50 UTC) #5

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages