Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137613003: win: Add windbg and command line debuggers to automatic toolchain (Closed)

Created:
6 years, 11 months ago by scottmg
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

win: Add windbg and command line debuggers to automatic toolchain R=maruel@chromium.org, jochen@chromium.org BUG=321187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245311

Patch Set 1 #

Patch Set 2 : back to win8 sdk, don't want to update yet #

Patch Set 3 : reitveld #

Total comments: 4

Patch Set 4 : fixes #

Patch Set 5 : reitveld #

Patch Set 6 : reitveld #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -11 lines) Patch
M win_toolchain/toolchain2013.py View 1 2 3 5 chunks +64 lines, -10 lines 0 comments Download
M win_toolchain/toolchain_vs2013.hash View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
6 years, 11 months ago (2014-01-15 21:44:35 UTC) #1
scottmg
6 years, 11 months ago (2014-01-16 20:16:30 UTC) #2
M-A Ruel
lgtm https://codereview.chromium.org/137613003/diff/190001/win_toolchain/toolchain2013.py File win_toolchain/toolchain2013.py (right): https://codereview.chromium.org/137613003/diff/190001/win_toolchain/toolchain2013.py#newcode123 win_toolchain/toolchain2013.py:123: """Download the Win8 SDK. Downloads https://codereview.chromium.org/137613003/diff/190001/win_toolchain/toolchain2013.py#newcode221 win_toolchain/toolchain2013.py:221: result ...
6 years, 11 months ago (2014-01-16 20:38:04 UTC) #3
scottmg
Thanks. https://codereview.chromium.org/137613003/diff/190001/win_toolchain/toolchain2013.py File win_toolchain/toolchain2013.py (right): https://codereview.chromium.org/137613003/diff/190001/win_toolchain/toolchain2013.py#newcode123 win_toolchain/toolchain2013.py:123: """Download the Win8 SDK. On 2014/01/16 20:38:04, M-A ...
6 years, 11 months ago (2014-01-16 20:42:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/137613003/310001
6 years, 11 months ago (2014-01-16 20:45:10 UTC) #5
commit-bot: I haz the power
Failed to apply patch for depot_tools/win_toolchain/toolchain_vs2013.hash: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-16 20:45:14 UTC) #6
scottmg
6 years, 11 months ago (2014-01-16 20:50:25 UTC) #7
Message was sent while issue was closed. 
Committed patchset #6 manually as r245311.

Powered by Google App Engine
This is Rietveld 408576698