Issue 137613002: Remove unnecessary WebGraphicsContext3D::reshape.. call from TestPlugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137613002: Remove unnecessary WebGraphicsContext3D::reshape.. call from TestPlugin (Closed)

Created:
6 years, 11 months ago by jamesr

Modified:
6 years, 11 months ago

Reviewers:
piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unnecessary WebGraphicsContext3D::reshape.. call from TestPlugin WebGraphicsContext3D::reshape..() resizes the default backbuffer, but the TestPlugin doesn't use the default backbuffer so this call is a no-op. BUG=181120 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245124

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	content/shell/renderer/test_runner/TestPlugin.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/137613002/1

6 years, 11 months ago (2014-01-14 01:01:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/137613002/1

6 years, 11 months ago (2014-01-14 23:33:59 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/137613002/1

6 years, 11 months ago (2014-01-15 04:09:50 UTC) #5

Message was sent while issue was closed.

Change committed as 245124

Expand Messages | Collapse Messages