Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1376123002: Revert of [Blob] BlobReader class & tests, and removal of all redundant reading. (Closed)

Created:
5 years, 2 months ago by kinuko
Modified:
5 years, 2 months ago
Reviewers:
michaeln, mmenke, dmurph
CC:
cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jsbell, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Blob] BlobReader class & tests, and removal of all redundant reading. (patchset #15 id:280001 of https://codereview.chromium.org/1337153002/ ) Reason for revert: BlobReaderTest.StateErrors failing on multiple bots. ../../content/browser/fileapi/blob_reader_unittest.cc:985: Failure Death test: reader_->Read(buffer.get(), 10, &bytes_read, base::Bind(&SetValue<int>, &async_bytes_read)) Result: failed to die. Error msg: [ DEATH ] Original issue's description: > [Blob] BlobReader class & tests, and removal of all redundant reading. > > * New BlobReader class & tests > * Removal of other reading code, which now uses the BlobReader > * Removal of unnecessary UploadDiskCacheEntryElementReader > * Removal of blob expansion logic in UploadDataStreamBuilder > > Now it's very easy for anyone in browserland to read blobs instead of > having to do url requests, and it's also easy for anyone to add new > blob backing storage. > > This is a prerequisite for the new blob async transportation, see here: > goto/BlobPaging > > BUG=138051, 375297 > > Committed: https://crrev.com/02561552a57ed8792a8ebb2676bad485e1d99605 > Cr-Commit-Position: refs/heads/master@{#351470} TBR=michaeln@chromium.org,mmenke@chromium.org,dmurph@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=138051, 375297 Committed: https://crrev.com/929e1ea7fa9fe4f5c76d2506bc4a9cc1d7a4c539 Cr-Commit-Position: refs/heads/master@{#351485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1514 lines, -2328 lines) Patch
D content/browser/fileapi/blob_reader_unittest.cc View 1 chunk +0 lines, -1109 lines 0 comments Download
M content/browser/fileapi/blob_url_request_job_unittest.cc View 4 chunks +4 lines, -27 lines 0 comments Download
M content/browser/loader/upload_data_stream_builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/upload_data_stream_builder.cc View 4 chunks +92 lines, -15 lines 0 comments Download
M content/browser/loader/upload_data_stream_builder_unittest.cc View 4 chunks +347 lines, -49 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
A net/base/upload_disk_cache_entry_element_reader.h View 1 chunk +72 lines, -0 lines 0 comments Download
A net/base/upload_disk_cache_entry_element_reader.cc View 1 chunk +90 lines, -0 lines 0 comments Download
A net/base/upload_disk_cache_entry_element_reader_unittest.cc View 1 chunk +331 lines, -0 lines 0 comments Download
M net/base/upload_element_reader.h View 2 chunks +6 lines, -0 lines 0 comments Download
M net/base/upload_element_reader.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/net.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M storage/browser/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M storage/browser/blob/blob_data_handle.h View 6 chunks +7 lines, -24 lines 0 comments Download
M storage/browser/blob/blob_data_handle.cc View 3 chunks +11 lines, -79 lines 0 comments Download
M storage/browser/blob/blob_data_snapshot.h View 1 chunk +0 lines, -1 line 0 comments Download
D storage/browser/blob/blob_reader.h View 1 chunk +0 lines, -190 lines 0 comments Download
D storage/browser/blob/blob_reader.cc View 1 chunk +0 lines, -569 lines 0 comments Download
M storage/browser/blob/blob_storage_context.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M storage/browser/blob/blob_url_request_job.h View 5 chunks +54 lines, -7 lines 0 comments Download
M storage/browser/blob/blob_url_request_job.cc View 10 chunks +470 lines, -104 lines 0 comments Download
M storage/browser/blob/blob_url_request_job_factory.h View 3 chunks +2 lines, -4 lines 0 comments Download
M storage/browser/blob/blob_url_request_job_factory.cc View 4 chunks +15 lines, -14 lines 0 comments Download
D storage/browser/blob/upload_blob_element_reader.h View 1 chunk +0 lines, -54 lines 0 comments Download
D storage/browser/blob/upload_blob_element_reader.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M storage/storage_browser.gyp View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinuko
Created Revert of [Blob] BlobReader class & tests, and removal of all redundant reading.
5 years, 2 months ago (2015-09-30 03:54:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376123002/1
5 years, 2 months ago (2015-09-30 03:55:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 03:56:53 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 03:57:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/929e1ea7fa9fe4f5c76d2506bc4a9cc1d7a4c539
Cr-Commit-Position: refs/heads/master@{#351485}

Powered by Google App Engine
This is Rietveld 408576698