Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1376113005: Revert of Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (patchset #3 id:40001 of https://codereview.chromium.org/1384873002/ ) Reason for revert: [Sheriff] Breaks the gcc 4.8 bot: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/3274 Original issue's description: > Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. > > Without that, it has a few false positives about out-of-bounds array accesses. > Also makes the clang static-analyzer happy. > > Original code review from Sven Panne: > https://codereview.chromium.org/790723002/ > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg > > Committed: https://crrev.com/d068574e641e28f05dcde89ddc9a1d0ec6f6f308 > Cr-Commit-Position: refs/heads/master@{#31105} TBR=jochen@chromium.org,bmeurer@chromium.org,karl@skomski.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/369d1c5ae185e53192ed8e6d192f81d88bcd079e Cr-Commit-Position: refs/heads/master@{#31112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -30 lines) Patch
M include/v8config.h View 6 chunks +0 lines, -17 lines 0 comments Download
M src/arguments.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/base/logging.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/base/platform/platform.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 ...
5 years, 2 months ago (2015-10-05 18:55:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376113005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376113005/1
5 years, 2 months ago (2015-10-05 18:55:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 18:56:18 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 18:56:36 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/369d1c5ae185e53192ed8e6d192f81d88bcd079e
Cr-Commit-Position: refs/heads/master@{#31112}

Powered by Google App Engine
This is Rietveld 408576698