chrome/browser/lifetime/application_lifetime_aura.cc - Issue 1376063005: Cleanup: Pull some browser keep alive functions into its own file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/application_lifetime_aura.cc

Issue 1376063005: Cleanup: Pull some browser keep alive functions into its own file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix build Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/lifetime/application_lifetime.cc ('k') | chrome/browser/lifetime/browser_close_manager_browsertest.cc » ('j') | chrome/browser/lifetime/browser_keep_alive.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/lifetime/application_lifetime_aura.cc

diff --git a/chrome/browser/lifetime/application_lifetime_aura.cc b/chrome/browser/lifetime/application_lifetime_aura.cc

index 75d67bae8588d0be4b9bddcc62e7089cd362d412..7ca523dddfc045707195cfa96005e682a829f7b2 100644

--- a/chrome/browser/lifetime/application_lifetime_aura.cc

+++ b/chrome/browser/lifetime/application_lifetime_aura.cc

@@ -7,6 +7,7 @@

#include "ash/shell.h"

#include "base/command_line.h"

#include "chrome/browser/browser_process.h"

+#include "chrome/browser/lifetime/browser_keep_alive.h"

#include "chrome/browser/notifications/notification_ui_manager.h"

#include "chrome/common/chrome_switches.h"

#include "ui/aura/client/capture_client.h"

@@ -35,7 +36,7 @@ void HandleAppExitingForPlatform() {

if (!base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kDisableZeroBrowsersOpenForTests)) {

// App is exiting, call DecrementKeepAliveCount() on behalf of Aura Shell.

- DecrementKeepAliveCount();

+ browser_lifetime::DecrementKeepAliveCount();

// Make sure we have notified the session manager that we are exiting.

// This might be called from FastShutdown() or CloseAllBrowsers(), but not

// if something prevents a browser from closing before SetTryingToQuit()