Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5320)

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 1376063005: Cleanup: Pull some browser keep alive functions into its own file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_sanity_browsertest.cc
diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc
index e8fc89c1a1fe1f95bb844b58132934314e4c3bc0..4eded2b632c5a2298608df4845a7fb20cf5077bb 100644
--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc
+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc
@@ -25,6 +25,7 @@
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/unpacked_installer.h"
#include "chrome/browser/lifetime/application_lifetime.h"
+#include "chrome/browser/lifetime/browser_keep_alive.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
@@ -180,8 +181,9 @@ class DevToolsSanityTest : public InProcessBrowserTest {
class DevToolsWindowBeforeUnloadObserver
: public content::WebContentsObserver {
public:
- explicit DevToolsWindowBeforeUnloadObserver(DevToolsWindow*);
+ explicit DevToolsWindowBeforeUnloadObserver(DevToolsWindow* devtools_window);
void Wait();
+
private:
// Invoked when the beforeunload handler fires.
void BeforeUnloadFired(const base::TimeTicks& proceed_time) override;
@@ -709,7 +711,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
content::WindowedNotificationObserver close_observer(
chrome::NOTIFICATION_BROWSER_CLOSED,
content::Source<Browser>(browser()));
- chrome::IncrementKeepAliveCount();
+ browser_lifetime::IncrementKeepAliveCount();
chrome::CloseAllBrowsers();
AcceptModalDialog();
AcceptModalDialog();
« no previous file with comments | « chrome/browser/chromeos/login/ui/login_display_host_impl.cc ('k') | chrome/browser/extensions/api/tabs/tabs_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698