Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: Source/bindings/v8/ScriptHeapSnapshot.cpp

Issue 137603004: Update more bindings classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/v8/ScriptProfiler.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010, Google Inc. All rights reserved. 2 * Copyright (c) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 return m_snapshot->GetUid(); 56 return m_snapshot->GetUid();
57 } 57 }
58 58
59 SnapshotObjectId ScriptHeapSnapshot::maxSnapshotJSObjectId() const 59 SnapshotObjectId ScriptHeapSnapshot::maxSnapshotJSObjectId() const
60 { 60 {
61 return m_snapshot->GetMaxSnapshotJSObjectId(); 61 return m_snapshot->GetMaxSnapshotJSObjectId();
62 } 62 }
63 63
64 namespace { 64 namespace {
65 65
66 class OutputStreamAdapter : public v8::OutputStream { 66 class OutputStreamAdapter FINAL : public v8::OutputStream {
67 public: 67 public:
68 OutputStreamAdapter(ScriptHeapSnapshot::OutputStream* output) 68 OutputStreamAdapter(ScriptHeapSnapshot::OutputStream* output)
69 : m_output(output) { } 69 : m_output(output) { }
70 void EndOfStream() { m_output->Close(); } 70 virtual void EndOfStream() OVERRIDE { m_output->Close(); }
71 int GetChunkSize() { return 102400; } 71 virtual int GetChunkSize() OVERRIDE { return 102400; }
72 WriteResult WriteAsciiChunk(char* data, int size) 72 virtual WriteResult WriteAsciiChunk(char* data, int size) OVERRIDE
73 { 73 {
74 m_output->Write(String(data, size)); 74 m_output->Write(String(data, size));
75 return kContinue; 75 return kContinue;
76 } 76 }
77 private: 77 private:
78 ScriptHeapSnapshot::OutputStream* m_output; 78 ScriptHeapSnapshot::OutputStream* m_output;
79 }; 79 };
80 80
81 } // namespace 81 } // namespace
82 82
83 void ScriptHeapSnapshot::writeJSON(ScriptHeapSnapshot::OutputStream* stream) 83 void ScriptHeapSnapshot::writeJSON(ScriptHeapSnapshot::OutputStream* stream)
84 { 84 {
85 OutputStreamAdapter outputStream(stream); 85 OutputStreamAdapter outputStream(stream);
86 m_snapshot->Serialize(&outputStream, v8::HeapSnapshot::kJSON); 86 m_snapshot->Serialize(&outputStream, v8::HeapSnapshot::kJSON);
87 } 87 }
88 88
89 } // namespace WebCore 89 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/v8/ScriptProfiler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698