Issue 137603004: Update more bindings classes to use OVERRIDE / FINAL when needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137603004: Update more bindings classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Update more bindings classes to use OVERRIDE / FINAL when needed Update more bindings classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. These were found using the chromium style clang plugin. R=haraken BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165041

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -34 lines)			Patch
M	Source/bindings/v8/ScriptHeapSnapshot.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/bindings/v8/ScriptProfiler.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/bindings/v8/SerializedScriptValue.cpp	View	17 chunks	+24 lines, -24 lines	0 comments	Download
M	Source/bindings/v8/V8AbstractEventListener.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/WorkerScriptDebugServer.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137603004/1

6 years, 11 months ago (2014-01-14 07:21:18 UTC) #3

Message was sent while issue was closed.

Change committed as 165041

Expand Messages | Collapse Messages