Make gyp work with Cygwin

Make gyp work with Cygwin

Committed: http://code.google.com/p/v8/source/detail?r=14282

[haitao.feng, 2013-04-07 03:22:50]

This patch includes https://codereview.chromium.org/13468015/. I will re-base
this one if 13468015 is accepted first.

The codes related to VirtualMemory are copied from platform-win32.cc. There are
two ways to remove this duplication.
1) Merge platform-cygwin with platform-win32
2) Split win32-virtual-memory from platform-win32
Please let me know which one you think is better.

There are 8 fails with ia32.release.check. Some of them are caused by
"::GetCurrentProcessId() is not equal with OS::GetCurrentProcessId()". The
others need some investigation.

[haitao.feng, 2013-04-16 03:04:21]

Rebased with master and added Sven as a reviewer.

There are 7 fails with make ia32.release.check in my Cygwin. Some of them are
caused by "::GetCurrentProcessId() is not equal with OS::GetCurrentProcessId()".
The others need some investigation.

[Sven Panne, 2013-04-16 06:21:34]

https://codereview.chromium.org/13760003/diff/6001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/13760003/diff/6001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:51: static bool IsNaN(double x) {
Why do we need this at all? Including math.h plus win32-math.* should be enough
to handle the platform differences, I think. This way, we could simply use
isnan() throughout this file.

[haitao.feng, 2013-04-16 08:17:21]

Verified on Windows Cygwin, Mingw and Visual Studio 2008.

https://codereview.chromium.org/13760003/diff/6001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/13760003/diff/6001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:51: static bool IsNaN(double x) {
On 2013/04/16 06:21:34, Sven Panne wrote:
> Why do we need this at all? Including math.h plus win32-math.* should be
enough
> to handle the platform differences, I think. This way, we could simply use
> isnan() throughout this file.

Done.

[Sven Panne, 2013-04-16 08:19:38]

LGTM from my side, if Jakob is OK with the GYP changes.

[Jakob Kummerow, 2013-04-16 08:27:24]

Looks like it should work on Cygwin; unfortunately it doesn't work on plain
Windows.

https://codereview.chromium.org/13760003/diff/14001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/13760003/diff/14001/tools/gyp/v8.gyp#newcode753
tools/gyp/v8.gyp:753: 'build_env': '<!(uname -o)',
This causes an error when running "python build\gyp_v8" in a plain Windows
(non-Cygwin, non-MinGW) command prompt.

[haitao.feng, 2013-04-16 09:16:58]

Fixed by assuming make generator is only used when uname is available. Please
help if you have a better solution.

[Jakob Kummerow, 2013-04-16 11:45:15]

lgtm

[Jakob Kummerow, 2013-04-16 12:36:53]

Committed patchset #4 manually as r14282 (presubmit successful).