Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1375963003: [heap] Add specific timer events for finalizing incremental GCs. (Closed)

Created:
5 years, 2 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Add specific timer events for finalizing incremental GCs. BUG= Committed: https://crrev.com/741c9552603e89970095871eff204e9fea491de0 Cr-Commit-Position: refs/heads/master@{#31103}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
M src/counters.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 2 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
lgtm https://codereview.chromium.org/1375963003/diff/20001/src/counters.h File src/counters.h (right): https://codereview.chromium.org/1375963003/diff/20001/src/counters.h#newcode492 src/counters.h:492: HT(gc_finalize_reduce, V8.GCFinalizeMCReduceMemory, 10000, MILLISECOND) \ Let's call it ...
5 years, 2 months ago (2015-10-05 14:55:59 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/1375963003/diff/20001/src/counters.h File src/counters.h (right): https://codereview.chromium.org/1375963003/diff/20001/src/counters.h#newcode492 src/counters.h:492: HT(gc_finalize_reduce, V8.GCFinalizeMCReduceMemory, 10000, MILLISECOND) \ On 2015/10/05 14:55:59, ulan ...
5 years, 2 months ago (2015-10-05 15:00:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375963003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375963003/40001
5 years, 2 months ago (2015-10-05 16:06:27 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-05 16:07:59 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 16:08:18 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/741c9552603e89970095871eff204e9fea491de0
Cr-Commit-Position: refs/heads/master@{#31103}

Powered by Google App Engine
This is Rietveld 408576698