Add SetAbortOnUncaughtExceptionCallback API

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** \mainpage V8 API Reference Guide
  *
  * V8 is Google's open source JavaScript engine.
  *
  * This set of documents provides reference material generated from the
  * V8 header file, include/v8.h.
@@ skipping 5360 matching lines @@
 
   /**
    * Returns the entered isolate for the current thread or NULL in
    * case there is no current isolate.
    *
    * This method must not be invoked before V8::Initialize() was invoked.
    */
   static Isolate* GetCurrent();
 
   /**
+   * Custom callback used by embedders to help V8 determine if it should abort
+   * when it throws and no internal handler can catch the exception.
+   * If FLAG_abort_on_uncaught_exception is true, then V8 will abort if either:

[Michael Starzinger, 2015/10/01 16:34:38]

nit: The "FLAG_abort_on_uncaught_exception" is an internal variable, in the
public API I would rather reference the "--abort-on-uncaught-exception" command
line flag, as that is something that the embedder can actually control.

Also I would rephrase the wording slightly to say "no internal handler is
predicted to catch the exception", because whether a finally-handler will
re-throw an exception or not is essentially an undecidable problem and hence
cannot be predicted at throw time. We essentially "predict" every
finally-handler will re-throw, which is just an assumption/guess on V8's part.

Also it might make sense to mentioned explicitly that if
"--abort-on-uncaught-exception" is not set, then the callback will never fire.

[Michael Starzinger, 2015/10/01 16:36:30]

Actually, I just realized: We conservatively assume any finally clause will
behave as if the exception were consumed. But that doesn't change the above
argument.

[julien.gilli, 2015/10/01 19:18:11]

Acknowledged.

[julien.gilli, 2015/10/01 19:18:11]

Acknowledged.

[julien.gilli, 2015/10/05 17:24:24]

Done.

[julien.gilli, 2015/10/05 17:24:24]

Done.

+   * - no custom callback is set.
+   * - the custom callback set returns true.
+   * Otherwise it won't abort.
+   */
+  typedef bool (*AbortOnUncaughtExceptionCallback)(Isolate*);
+  void SetAbortOnUncaughtExceptionCallback(
+      AbortOnUncaughtExceptionCallback callback);
+
+  /**
    * Methods below this point require holding a lock (using Locker) in
    * a multi-threaded environment.
    */
 
   /**
    * Sets this isolate as the entered one for the current thread.
    * Saves the previously entered one (if any), so that it can be
    * restored when exiting.  Re-entering an isolate is allowed.
    */
   void Enter();
@@ skipping 2963 matching lines @@
  */
 
 
 }  // namespace v8
 
 
 #undef TYPE_CHECK
 
 
 #endif  // V8_H_