Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1375913003: Multicol: Add test that re-lays out a float and pushes it downwards at the same time. (Closed)

Created:
5 years, 2 months ago by mstensho (USE GERRIT)
Modified:
5 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Multicol: Add test that re-lays out a float and pushes it downwards at the same time. The test passes, but the code seems somewhat brittle, so better make sure that it keeps working. Inline-level layout of floats is weird. LayoutBlockFlow::layoutInlineChildren() lays out the float before its position is updated, and then marks the lines that it thinks are affected as dirty (it may find the wrong lines here, but I haven't been able to make anything fail because of it). For pagination this additionally means that the pagination strut may be wrong (since the float's position hasn't been updated). Luckily, we get an opportunity to lay out again in insertFloatingObject() (still at the old position, though), and yet another opportunity in positionNewFloats() (this time at the updated position). R=jchaffraix@chromium.org,leviw@chromium.org,robhogan@gmail.com Committed: https://crrev.com/011ad4bb05558061cb4c8caf0204b552c3f9d77d Cr-Commit-Position: refs/heads/master@{#352587}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review. Now 20% more BR-free. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/relayout-and-push-float.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/relayout-and-push-float-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mstensho (USE GERRIT)
5 years, 2 months ago (2015-09-29 14:22:57 UTC) #1
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/1375913003/diff/1/third_party/WebKit/LayoutTests/fast/multicol/relayout-and-push-float.html File third_party/WebKit/LayoutTests/fast/multicol/relayout-and-push-float.html (right): https://codereview.chromium.org/1375913003/diff/1/third_party/WebKit/LayoutTests/fast/multicol/relayout-and-push-float.html#newcode11 third_party/WebKit/LayoutTests/fast/multicol/relayout-and-push-float.html:11: <br> Are both of these br's necessary?
5 years, 2 months ago (2015-10-06 10:54:03 UTC) #2
mstensho (USE GERRIT)
https://codereview.chromium.org/1375913003/diff/1/third_party/WebKit/LayoutTests/fast/multicol/relayout-and-push-float.html File third_party/WebKit/LayoutTests/fast/multicol/relayout-and-push-float.html (right): https://codereview.chromium.org/1375913003/diff/1/third_party/WebKit/LayoutTests/fast/multicol/relayout-and-push-float.html#newcode11 third_party/WebKit/LayoutTests/fast/multicol/relayout-and-push-float.html:11: <br> On 2015/10/06 10:54:02, leviw wrote: > Are both ...
5 years, 2 months ago (2015-10-06 11:31:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375913003/20001
5 years, 2 months ago (2015-10-06 11:31:46 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-06 12:24:43 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 12:26:27 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/011ad4bb05558061cb4c8caf0204b552c3f9d77d
Cr-Commit-Position: refs/heads/master@{#352587}

Powered by Google App Engine
This is Rietveld 408576698