Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1375913002: KeyAccumulator: tweaking parameters for benchmarks (Closed)

Created:
5 years, 2 months ago by Camillo Bruni
Modified:
5 years, 2 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@2015-09-08_hasOwnProperty_perf_GetKeys_v2904_1316213008
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

KeyAccumulator: tweaking parameters for benchmarks R=ishell@chromium.org BUG=chromium:536790 LOG=N Committed: https://crrev.com/6b629ef76cd629b5ddcdb5891d949dcd70112ea9 Cr-Commit-Position: refs/heads/master@{#31039}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixing nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/objects.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
Igor Sheludko
lgtm https://codereview.chromium.org/1375913002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1375913002/diff/1/src/objects.cc#newcode6795 src/objects.cc:6795: // These limit were obtained through evaluation of ...
5 years, 2 months ago (2015-10-01 06:41:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375913002/20001
5 years, 2 months ago (2015-10-01 06:56:33 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-01 07:20:35 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 07:20:59 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b629ef76cd629b5ddcdb5891d949dcd70112ea9
Cr-Commit-Position: refs/heads/master@{#31039}

Powered by Google App Engine
This is Rietveld 408576698