Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: components/password_manager/core/browser/password_store_unittest.cc

Issue 1375883002: Support Android username-only credentials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: engedy@ comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_store.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_store_unittest.cc
diff --git a/components/password_manager/core/browser/password_store_unittest.cc b/components/password_manager/core/browser/password_store_unittest.cc
index d94445d95416577534e3b6d7fcdfbbf1efb8b733..9e91167f298546065e2b5083f0d4b7ac70c912e4 100644
--- a/components/password_manager/core/browser/password_store_unittest.cc
+++ b/components/password_manager/core/browser/password_store_unittest.cc
@@ -501,6 +501,12 @@ TEST_F(PasswordStoreTest, GetLoginsWithAffiliations) {
"", "", L"", L"", L"",
L"username_value_3b",
L"", true, true, 1},
+ // Third credential for the same application which is username-only.
+ {PasswordForm::SCHEME_USERNAME_ONLY,
+ kTestAndroidRealm1,
+ "", "", L"", L"", L"",
+ L"username_value_3c",
+ L"", true, true, 1},
// Credential for another Android application affiliated with the realm
// of the observed from.
{PasswordForm::SCHEME_HTML,
@@ -552,7 +558,7 @@ TEST_F(PasswordStoreTest, GetLoginsWithAffiliations) {
expected_results.push_back(new PasswordForm(*all_credentials[1]));
expected_results.push_back(new PasswordForm(*all_credentials[2]));
expected_results.push_back(new PasswordForm(*all_credentials[3]));
- expected_results.push_back(new PasswordForm(*all_credentials[4]));
+ expected_results.push_back(new PasswordForm(*all_credentials[5]));
for (PasswordForm* result : expected_results) {
if (result->signon_realm != observed_form.signon_realm &&
!IsValidAndroidFacetURI(result->signon_realm))
« no previous file with comments | « components/password_manager/core/browser/password_store.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698