components/password_manager/core/browser/login_database.cc - Issue 1375883002: Support Android username-only credentials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/login_database.cc

Issue 1375883002: Support Android username-only credentials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: engedy@ comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/login_database.cc

diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc

index 30199b4d00f5b3e31c1687e68add04780b327cc8..f241b0080ab8824878a57f92bfdce11998aaa0b5 100644

--- a/components/password_manager/core/browser/login_database.cc

+++ b/components/password_manager/core/browser/login_database.cc

@@ -1020,7 +1020,8 @@ LoginDatabase::EncryptionResult LoginDatabase::InitPasswordFormFromStatement(

base::Time::FromInternalValue(s.ColumnInt64(COLUMN_DATE_CREATED));

form->blacklisted_by_user = (s.ColumnInt(COLUMN_BLACKLISTED_BY_USER) > 0);

int scheme_int = s.ColumnInt(COLUMN_SCHEME);

- DCHECK((scheme_int >= 0) && (scheme_int <= PasswordForm::SCHEME_OTHER));

+ DCHECK_LE(0, scheme_int);

+ DCHECK_GE(PasswordForm::SCHEME_LAST, scheme_int);

form->scheme = static_cast<PasswordForm::Scheme>(scheme_int);

int type_int = s.ColumnInt(COLUMN_PASSWORD_TYPE);

DCHECK(type_int >= 0 && type_int <= PasswordForm::TYPE_GENERATED);