components/password_manager/core/browser/credential_manager_pending_request_task.cc - Issue 1375883002: Support Android username-only credentials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_pending_request_task.cc

Issue 1375883002: Support Android username-only credentials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/affiliated_match_helper.cc ('K') | « components/password_manager/core/browser/affiliated_match_helper_unittest.cc ('k') | components/password_manager/core/browser/login_database.cc » ('j') | components/password_manager/core/browser/password_store.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_pending_request_task.cc

diff --git a/components/password_manager/core/browser/credential_manager_pending_request_task.cc b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

index f51edc8805ea765b50702044bc52dcc69ffbf1cc..bc79dc545e6c85090a48f2e2e485053a2476af36 100644

--- a/components/password_manager/core/browser/credential_manager_pending_request_task.cc

+++ b/components/password_manager/core/browser/credential_manager_pending_request_task.cc

@@ -70,6 +70,8 @@ void CredentialManagerPendingRequestTask::OnGetPasswordStoreResults(

// TODO(mkwst): This doesn't create a PasswordForm that we can use to create

// a FederatedCredential (via CreatePasswordFormFromCredentialInfo). We need

// to fix that.

+ AffiliatedMatchHelper::TrimAndroidUsernameOnlyCredentials(

+ &affiliated_results);

local_results.insert(local_results.end(), affiliated_results.begin(),

affiliated_results.end());

affiliated_results.weak_clear();