Issue 1375843004: Remove obsolete lookup-inl.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1375843004: Remove obsolete lookup-inl.h header. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger

Modified:
5 years, 2 months ago

Reviewers:
Toon Verwaest

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove obsolete lookup-inl.h header. This removes the lookup-inl.h header file, which actually would break compilation if included more than once in the codebase. It only holds methods used solely in the lookup.cc compilation unit. R=verwaest@chromium.org Committed: https://crrev.com/13adffcba800643b183c257b92b066ec0645ee7b Cr-Commit-Position: refs/heads/master@{#31104}

Patch Set 1 #

Patch Set 2 : Fix includes. #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -145 lines)			Patch
M	BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/lookup.cc	View	1	2 chunks	+127 lines, -1 line	0 comments	Download
D	src/lookup-inl.h	View		1 chunk	+0 lines, -142 lines	0 comments	Download
M	tools/gyp/v8.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375843004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375843004/20001

5 years, 2 months ago (2015-10-05 16:21:38 UTC) #4

commit-bot: I haz the power

5 years, 2 months ago (2015-10-05 16:23:55 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/13adffcba800643b183c257b92b066ec0645ee7b
Cr-Commit-Position: refs/heads/master@{#31104}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages