Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1375833003: Chrome currently doesn't ignore transitions when using "@media print" (Closed)

Created:
5 years, 2 months ago by nainar
Modified:
5 years, 2 months ago
Reviewers:
dstockwell, Timothy Loh
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome currently doesn't ignore transitions when using "@media print" styles. FF does ignore transitions. This also includes a Layout Test. BUG=412281 Committed: https://crrev.com/39a296120585ce464ccffaeb8ed2067ee1ba56d9 Cr-Commit-Position: refs/heads/master@{#351742}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix patch and remove layout test #

Patch Set 4 : Set wasPrinting in constructor #

Patch Set 5 : Working patch and layout test #

Patch Set 6 : Space issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/printing/printing-transition-ignore-media-print.html View 1 2 3 4 5 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
nainar
PTAL? Thanks!
5 years, 2 months ago (2015-09-29 06:02:26 UTC) #2
Timothy Loh
On 2015/09/29 06:02:26, nainar wrote: > PTAL? > > Thanks! This doesn't fully fix the ...
5 years, 2 months ago (2015-09-29 06:14:38 UTC) #3
nainar
Working on Layout Test, could you take a look at the patch in the meanwhile?
5 years, 2 months ago (2015-09-30 01:49:18 UTC) #4
nainar
Hi! I've uploaded both the working patch and the Layout Test, PTAL? Thanks!
5 years, 2 months ago (2015-10-01 03:30:36 UTC) #5
dstockwell
lgtm
5 years, 2 months ago (2015-10-01 03:41:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375833003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375833003/100001
5 years, 2 months ago (2015-10-01 03:47:24 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 2 months ago (2015-10-01 07:04:01 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 07:04:51 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/39a296120585ce464ccffaeb8ed2067ee1ba56d9
Cr-Commit-Position: refs/heads/master@{#351742}

Powered by Google App Engine
This is Rietveld 408576698