Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 137583010: [Cleanup]Removing changes associated with setting visualWordMovement since it is never used. (Closed)

Created:
6 years, 11 months ago by Sunil Ratnu
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Removing changes associated with setting visualWordMovement since it is never used. Since the setting visualWordMovement is not used anywhere,so removing all the changes associated with it. visualWordMovementEnabled() method is not called anywhere. The dependent chromium side changes that have to land first can be found here : https://codereview.chromium.org/139853011/ BUG=355009 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172340

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/core/frame/Settings.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M public/web/WebSettings.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Sunil Ratnu
Please have a look.
6 years, 11 months ago (2014-01-23 14:54:06 UTC) #1
abarth-chromium
lgtm
6 years, 11 months ago (2014-01-23 20:54:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/137583010/1
6 years, 11 months ago (2014-01-23 20:54:23 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 11 months ago (2014-01-23 21:47:45 UTC) #4
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 8 months ago (2014-04-22 17:54:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/137583010/1
6 years, 8 months ago (2014-04-22 17:55:09 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 17:55:22 UTC) #7
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/Settings.in: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-22 17:55:22 UTC) #8
Sunil Ratnu
The CQ bit was checked by sunil.ratnu@samsung.com
6 years, 8 months ago (2014-04-23 06:21:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/137583010/220001
6 years, 8 months ago (2014-04-23 06:22:31 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 07:39:54 UTC) #11
Message was sent while issue was closed.
Change committed as 172340

Powered by Google App Engine
This is Rietveld 408576698