Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 137583006: Remove tests for unused IDL compiler features (Closed)

Created:
6 years, 11 months ago by Nils Barth (inactive)
Modified:
6 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Remove tests for unused IDL compiler features Remove tests for unused features: * sequence<SerializedScriptValue> * [Immutable] on non-SVG attributes * readonly constructor attributes * static constructor attributes Now Python passes TestTypedefs.idl! TBR=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165026

Patch Set 1 #

Patch Set 2 : Remove other unused line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -42 lines) Patch
M Source/bindings/tests/idls/TestObject.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/TestTypedefs.idl View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 5 chunks +3 lines, -32 lines 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
6 years, 11 months ago (2014-01-14 03:49:49 UTC) #1
haraken
LGTM
6 years, 11 months ago (2014-01-14 03:57:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/137583006/40001
6 years, 11 months ago (2014-01-14 04:07:46 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 04:28:38 UTC) #4
Message was sent while issue was closed.
Change committed as 165026

Powered by Google App Engine
This is Rietveld 408576698