Issue 137583005: resolveScopedKeyframesRules should check @keyframes declared in shadow trees.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137583005: resolveScopedKeyframesRules should check @keyframes declared in shadow trees. (Closed)

Created:
6 years, 11 months ago by tasak

Modified:
6 years, 11 months ago

Reviewers:
dglazkov

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

resolveScopedKeyframesRules should check @keyframes declared in shadow trees. If a given element is a shadow host, we need to check @keyframe rules declared in shadow trees hosted by the element. BUG=332577 TEST=fast/dom/shadow/shadowhost-keyframes.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165156

Patch Set 1 #

Patch Set 2 : Added layout test #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -0 lines)			Patch
A	LayoutTests/fast/dom/shadow/shadowhost-keyframes.html	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/shadow/shadowhost-keyframes-expected.txt	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/core/css/resolver/ScopedStyleTree.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/137583005/30001

6 years, 11 months ago (2014-01-15 18:49:35 UTC) #3

Message was sent while issue was closed.

Change committed as 165156

Expand Messages | Collapse Messages