third_party/WebKit/Source/core/svg/SVGFETurbulenceElement.cpp - Issue 1375793003: Update error-handling for fe*Lighting and feTurbulence

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGFETurbulenceElement.cpp

Issue 1375793003: Update error-handling for fe*Lighting and feTurbulence (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGFETurbulenceElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGFETurbulenceElement.cpp b/third_party/WebKit/Source/core/svg/SVGFETurbulenceElement.cpp

index 59d104ce06cea478562f27b97801d38e363dda93..87427f09d0fe3205b37d89ca6d69178efa8a18df 100644

--- a/third_party/WebKit/Source/core/svg/SVGFETurbulenceElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGFETurbulenceElement.cpp

@@ -80,7 +80,7 @@ bool SVGFETurbulenceElement::setFilterEffectAttribute(FilterEffect* effect, cons

if (attrName == SVGNames::typeAttr)

return turbulence->setType(m_type->currentValue()->enumValue());

if (attrName == SVGNames::stitchTilesAttr)

- return turbulence->setStitchTiles(m_stitchTiles->currentValue()->enumValue());

+ return turbulence->setStitchTiles(m_stitchTiles->currentValue()->enumValue() == SVG_STITCHTYPE_STITCH);

if (attrName == SVGNames::baseFrequencyAttr) {

bool baseFrequencyXChanged = turbulence->setBaseFrequencyX(baseFrequencyX()->currentValue()->value());

bool baseFrequencyYChanged = turbulence->setBaseFrequencyY(baseFrequencyY()->currentValue()->value());

@@ -112,9 +112,13 @@ void SVGFETurbulenceElement::svgAttributeChanged(const QualifiedName& attrName)

PassRefPtrWillBeRawPtr<FilterEffect> SVGFETurbulenceElement::build(SVGFilterBuilder*, Filter* filter)

{

- if (baseFrequencyX()->currentValue()->value() < 0 || baseFrequencyY()->currentValue()->value() < 0)

- return nullptr;

- return FETurbulence::create(filter, m_type->currentValue()->enumValue(), baseFrequencyX()->currentValue()->value(), baseFrequencyY()->currentValue()->value(), m_numOctaves->currentValue()->value(), m_seed->currentValue()->value(), m_stitchTiles->currentValue()->enumValue() == SVG_STITCHTYPE_STITCH);

+ return FETurbulence::create(filter,

+ m_type->currentValue()->enumValue(),

+ baseFrequencyX()->currentValue()->value(),

+ baseFrequencyY()->currentValue()->value(),

+ m_numOctaves->currentValue()->value(),

+ m_seed->currentValue()->value(),

+ m_stitchTiles->currentValue()->enumValue() == SVG_STITCHTYPE_STITCH);

}

} // namespace blink