Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1375773004: Revert of [Oilpan] Move MediaStream{Source|Component|Descriptor} to Oilpan heap (Closed)

Created:
5 years, 2 months ago by Finnur
Modified:
5 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Oilpan] Move MediaStream{Source|Component|Descriptor} to Oilpan heap (patchset #9 id:140001 of https://codereview.chromium.org/1363143003/ ) Reason for revert: Suspecting it broke at least for bots on the waterfall, e.g.: https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/9048 Original issue's description: > Move MediaStream{Source|Component|Descriptor} to Oilpan heap > > BUG=496535 > > Committed: https://crrev.com/622d290d58d54d6c1410d19ecb88b5c2dd2d135d > Cr-Commit-Position: refs/heads/master@{#352008} TBR=tkent@chromium.org,haraken@chromium.org,oilpan-reviews@chromium.org,sigbjornf@opera.com,yutak@chromium.org,peria@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=496535 Committed: https://crrev.com/9cffd8b3cda241f10b96425a2ad0a73f4a58657b Cr-Commit-Position: refs/heads/master@{#352021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -113 lines) Patch
M third_party/WebKit/Source/modules/mediastream/MediaStream.h View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.cpp View 6 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamRegistry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 4 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaRequest.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStream.cpp View 2 chunks +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStreamTrack.cpp View 3 chunks +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.h View 4 chunks +6 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.cpp View 2 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.h View 4 chunks +11 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.cpp View 5 chunks +11 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h View 5 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp View 3 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaStream.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebMediaStreamSource.h View 3 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaStreamTrack.h View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Finnur
Created Revert of [Oilpan] Move MediaStream{Source|Component|Descriptor} to Oilpan heap
5 years, 2 months ago (2015-10-02 13:34:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375773004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375773004/1
5 years, 2 months ago (2015-10-02 13:34:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 13:36:54 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9cffd8b3cda241f10b96425a2ad0a73f4a58657b Cr-Commit-Position: refs/heads/master@{#352021}
5 years, 2 months ago (2015-10-02 13:37:59 UTC) #4
haraken
LGTM
5 years, 2 months ago (2015-10-02 13:58:20 UTC) #5
peria
5 years, 2 months ago (2015-10-02 14:00:05 UTC) #6
Message was sent while issue was closed. 
LGTM, thank you for this revert.

Powered by Google App Engine
This is Rietveld 408576698