Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1360)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

Issue 1375753002: Move font shorthand handling into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch for landing Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
index 3eb8530965d459f6f5c7fb5ea7eca7d4e39d22e0..d8e62d85b34a8472d39f0c4bf1dd067edae447c9 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
@@ -193,9 +193,8 @@ private:
PassRefPtrWillBeRawPtr<CSSBasicShapePolygonValue> parseBasicShapePolygon(CSSParserValueList* args);
PassRefPtrWillBeRawPtr<CSSBasicShapeInsetValue> parseBasicShapeInset(CSSParserValueList* args);
- bool parseFont(bool important);
- bool parseSystemFont(bool important);
- PassRefPtrWillBeRawPtr<CSSValueList> parseFontFamily();
+ bool consumeFont(bool important);
+ bool consumeSystemFont(bool important);
PassRefPtrWillBeRawPtr<CSSValue> parseCounter(int defaultValue);
PassRefPtrWillBeRawPtr<CSSValue> parseCounterContent(CSSParserValueList* args, bool counters);
@@ -207,9 +206,6 @@ private:
bool acceptQuirkyColors(CSSPropertyID) const;
- PassRefPtrWillBeRawPtr<CSSPrimitiveValue> parseLineHeight();
- bool parseFontSize(bool important);
- bool parseFontWeight(bool important);
PassRefPtrWillBeRawPtr<CSSValueList> consumeFontFaceSrc();
bool parseSVGValue(CSSPropertyID propId, bool important);
@@ -372,7 +368,6 @@ private:
// Outputs:
WillBeHeapVector<CSSProperty, 256>& m_parsedProperties;
- StyleRule::Type m_ruleType;
// Locals during parsing:
int m_inParseShorthand;

Powered by Google App Engine
This is Rietveld 408576698