Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 1375743002: Revert of exclude PhishingDOMFeatureExtractorTest.* browser_tests on Dr. Memory bots (Closed)

Created:
5 years, 2 months ago by erikchen
Modified:
5 years, 2 months ago
Reviewers:
zhaoqin1
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of exclude PhishingDOMFeatureExtractorTest.* browser_tests on Dr. Memory bots (patchset #1 id:1 of https://codereview.chromium.org/1371193003/ ) Reason for revert: I'm reverting the relevant CL, https://codereview.chromium.org/1373993002/ so this exclusion is no longer necessary. Original issue's description: > exclude PhishingDOMFeatureExtractorTest.* browser_tests on Dr. Memory bots > > TBR=erikchen@chromium.org > BUG=536891 > NOTRY=true > > Committed: https://crrev.com/2b4bfec5eab7ab8986557934ef9bd27e87c8e22b > Cr-Commit-Position: refs/heads/master@{#351107} TBR=zhaoqin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=536891 Committed: https://crrev.com/bcfea02ff4fea4428ca58509b69890b0503d8dfa Cr-Commit-Position: refs/heads/master@{#351129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of exclude PhishingDOMFeatureExtractorTest.* browser_tests on Dr. Memory bots
5 years, 2 months ago (2015-09-28 20:26:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375743002/1
5 years, 2 months ago (2015-09-28 20:27:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 20:29:16 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 20:31:43 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcfea02ff4fea4428ca58509b69890b0503d8dfa
Cr-Commit-Position: refs/heads/master@{#351129}

Powered by Google App Engine
This is Rietveld 408576698